Skip to content

chore(tests): Fix broken rector run due to conflict with psalm#62034

Open
DerDreschner wants to merge 1 commit into
masterfrom
fix/run-ci-changes
Open

chore(tests): Fix broken rector run due to conflict with psalm#62034
DerDreschner wants to merge 1 commit into
masterfrom
fix/run-ci-changes

Conversation

@DerDreschner

@DerDreschner DerDreschner commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

The CI pipeline against master is currently failing because rector:strict is failing. The attempted changes can't be made, as they conflict with the psalm rules. Therefore, I've decided to add the error message to the exception list.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@DerDreschner DerDreschner requested a review from a team as a code owner July 13, 2026 02:23
@DerDreschner DerDreschner added 3. to review Waiting for reviews CI labels Jul 13, 2026
@DerDreschner DerDreschner requested review from CarlSchwan, come-nc, icewind1991 and provokateurin and removed request for a team July 13, 2026 02:23
@DerDreschner DerDreschner changed the title chore: Run rector:strict to fix broken CI pipeline chore(tests): Fix broken rector run due to conflict with psalm Jul 13, 2026
@DerDreschner DerDreschner added the tests Related to tests label Jul 13, 2026
Comment thread build/rector-strict.php Outdated
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
@DerDreschner DerDreschner requested a review from come-nc July 13, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted CI tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants